Add Enum Eq #2552
Merged
Add Enum Eq #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
May 28, 2017
| // : Eq[C[T1$1, ..., Tn$1], C[T1$2, ..., Tn$2]] = Eq | ||
| def eqInstance = { | ||
| def append(tdef: TypeDef, str: String) = cpy.TypeDef(tdef)(name = tdef.name ++ str) | ||
| val leftParams = derivedTparams.map(append(_, "$1")) |
There was a problem hiding this comment.
Any reason to not use semantic names here?
There was a problem hiding this comment.
Yes, we could do that.
There was a problem hiding this comment.
On the other hand, maybe it's not worth the hassle. The names literally don't matter.
Need reflexive instances so that eqAny does not kick in.
xeno-by
reviewed
May 28, 2017
| If all you do with `y` is compare it to other values of type `T`, the program will | ||
| typecheck but probably give unexpected results. | ||
|
|
||
| Multiversal equaliy is an opt-in way to make universal equality |
xeno-by
reviewed
May 28, 2017
| The `dotty.DottyPredef` object defines a number of `Eq` | ||
| implicits. `dotty.DottyPredef` is a temporary `Predef`-like object. | ||
| The contents of this object are by default imported into every | ||
| program. Once dotty becomes standard Scala, `DottyPredef` will go away |
There was a problem hiding this comment.
What's the standard spelling of Dotty? "dotty", "Dotty", context-dependent? When does one capitalize?
There was a problem hiding this comment.
Ok, let's settle on capitalizing it
xeno-by
reviewed
May 28, 2017
| --- | ||
| layout: doc-page | ||
| title: "Named Type Arguments" | ||
| --- |
There was a problem hiding this comment.
It would also be great to have a page about implicit function types.
|
@senia-psm Fixing it, thanks! |
Needed to pass multiversal equality rules.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an Eq instance to every Enum so that they can be compared only to other values of the same type.