Add dotty-doc to dist #2537
Add dotty-doc to dist #2537
Conversation
bin/dotd
Outdated
| CLASS_PATH="$CLASS_PATH$PSEP$AUTOLINK_LIB" | ||
| CLASS_PATH="$CLASS_PATH$PSEP$SNAKEYAML_LIB" | ||
| CLASS_PATH="$CLASS_PATH$PSEP$ST4_LIB" | ||
| CLASS_PATH="$CLASS_PATH$PSEP$JSOUP_LIB" |
There was a problem hiding this comment.
Each line is an isolated dep, allowing us to delete them as they disappear over time.
There was a problem hiding this comment.
Would be nice to test this script. Because it hardcodes list of dependencies it is very fragile
There was a problem hiding this comment.
Not sure any of the dist scripts are testable like this currently. We'd need to trigger dist/pack-archive then run the scripts I guess.
WDYT @liufengyun ?
There was a problem hiding this comment.
Currently we have a simple CI to check if a release can compile and run a hello world on OSX. The CI runs on Travis, and it's triggered everytime we update the formula.
We can also add dotd to the same CI to make sure it completes normally.
felixmulder
force-pushed
the
topic/add-dottydoc-to-dist
branch
from
2f79d97 to
1eb3957
Compare
dist/bin/dotd
Outdated
|
|
||
| first_arg="$1" | ||
|
|
||
| echo $JAVACMD dotty.tools.dottydoc.Main $CLASS_PATH |
There was a problem hiding this comment.
This line is just for testing?
There was a problem hiding this comment.
Ah yes, will remove
dist/bin/dotd
Outdated
|
|
||
| echo $JAVACMD dotty.tools.dottydoc.Main $CLASS_PATH | ||
|
|
||
| eval exec "\"$JAVACMD\"" $CLASS_PATH dotty.tools.dottydoc.Main $@ |
There was a problem hiding this comment.
BTW, do we need the Scala classpath for compiling the source? The dotc script has Dscala.usejavacp=true or -Xbootclasspath/a:$classpath, so it's not required.
There was a problem hiding this comment.
@felixmulder I guess you missed this comment?
No description provided.