Fix #2421: Add errors for inline on non supported trees #2476
Conversation
|
@nicolasstucki - needs rebase |
| val sym = tree.symbol | ||
| if (sym is Inline) { | ||
| tree match { | ||
| case _: TypeDef => |
There was a problem hiding this comment.
There is already a method checkFlags in Namer. I think it's cleaner to integrate with that method. Can you try to use the logic of that method to formulate your tests?
The checkFlags method also has the advantage that it will not let illegal flags be added to symbols. We should keep that property.
nicolasstucki
force-pushed
the
fix-#2421
branch
2 times, most recently
from
ba009b5 to
82ac78d
Compare
|
Moved checks to checkFlags |
|
All requested changes were addressed. |
Check modifiers `lazy` and `inline` for inapplicability
|
@odersky it looks like your commits lost the test file https://github.com/dotty-staging/dotty/blob/ee331a6fa255638c8db59dae269198d3a8c3dba9/tests/neg/i2421.scala |
|
I found a solution that requires less code and fits better. @nicolasstucki do you want to review? |
| fail(i"illegal combination of modifiers: $flag1 and $flag2 for: $sym") | ||
| fail(i"illegal combination of modifiers: `$flag1` and `$flag2` for: $sym") | ||
| def checkApplicable(flag: FlagSet, ok: Boolean) = | ||
| if (!ok && !sym.is(Synthetic)) |
There was a problem hiding this comment.
Why is the !sym.is(Synthetic) needed here? Is it only for the lazy val of the modules?
There was a problem hiding this comment.
For now yes, but there might be other synthetic symbols with conflicts. In any case, if it is synthetic we should not issue an error message to the user.
|
LGTM |
No description provided.