Fix #2368: local variables must be initialized #2423
Conversation
|
As this is not dirrectly related to typing, I'd propose to move the check to RefChecks. This is a phase that implements a lot of sanity checks that could be factored out from typer. The general approach looks good to me. |
|
Honestly, I'd rather have more checks early if possible instead of doing them in RefChecks, unless we manage to move RefChecks earlier. In the IDE I currently run with |
|
Another benefit of doing the check in the typer is that these checks will be done when retyping (either in Erasure or Ycheck), which could catch issues. |
|
@smarter, I think we should just have an entirely separate pipeline for IDE and run it until erasure(this pipeline won't include sbt related phases, Pickler and other phases that don't report errors). There are important errors that only get reported by erasure. |
Disallow var declarations initialized to a placholder, if the var declaration is local. `var x: Foo = _` is still allowed in fields. Testing ======= Added tests for both invariants above.
|
Yes, that might be a good idea. Though for Erasure for example, I wonder if we could avoid running the whole phase and just check signatures to avoid methods with the same erased signature, etc. |
|
Sounds like there's consensus for leaving the check in refchecks, then? Moved it there. PTAL. |
Disallow var declarations initialized to a placholder, if
the var declaration is local.
var x: Foo = _is still allowed in fields.Testing
Added tests for both invariants above.