Moved Method Does Not Take (More) Parameters error to case class #2357
Conversation
|
|
||
| val explanation = | ||
| hl"""|You have specified more parameter lists as defined in the method definition(s). | ||
| |In case ${err.refStr(methPartType)} is defined without parenthesis, you may |
There was a problem hiding this comment.
You should be able to only display this when methPartType is actually defined without parenthesis. I think methPartType.isInstanceOf[ExprType] should check for that.
There was a problem hiding this comment.
Great, was looking around for an easy enough check to do just that.
There was a problem hiding this comment.
@smarter I find a TermRefWithSignature in my samples, do I need to test for just that?
There was a problem hiding this comment.
Try methPartType.widenSingleton.isInstanceOf[ExprType]
There was a problem hiding this comment.
(A TermRef might not always be a reference to a method with no arguments, so we widen it to its underlying type and check that)
|
Also needs rebase, then LGTM |
ennru
force-pushed
the
ennru_MethodDoesNotTakeParameters
branch
from
7519e6e to
9c0d0dd
Compare
|
@dotty-bot: could you recheck please? |
|
Sure thing, I got your back! ❤️ |
@felixmulder Same solution regarding
typer.ErrorReporting.Errorshere.