Do not accidentally force diagnostic message in reportWarning
#2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
force-pushed
the
topic/cleanup-spree
branch
from
cb436b3 to
49c8744
Compare
Diagnostic messages are contained within a `MessageContainer` which takes the message by name. This is in order for the compiler to be able to throw away messages without evaluting potentially costly operations. Calling `.contained` breaks this laziness.
felixmulder
force-pushed
the
topic/cleanup-spree
branch
from
49c8744 to
ee1160c
Compare
smarter
approved these changes
May 2, 2017
|
One way would be to call it |
smarter
changed the title
reportWarning doesn't break by namereportWarning
felixmulder
force-pushed
the
topic/cleanup-spree
branch
from
8dcedc7 to
69bbf85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.