Fix #2345: Handle case of overloaded local vars in assignment #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up logic of typedAssign, so that it now correctly handles the case of an overloaded left-hand-side consisting of a provate[this] var and one or more methods.
smarter
reviewed
May 2, 2017
| @@ -567,37 +567,42 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit | |||
| case lhs => | |||
| val lhsCore = typedUnadapted(lhs, AssignProto) | |||
| def lhs1 = typed(untpd.TypedSplice(lhsCore)) | |||
| def canAssign(sym: Symbol) = // allow assignments from the primary constructor to class fields | |||
| lazy val lhsVal = lhsCore.asInstanceOf[TermRef].denot.suchThat(!_.is(Method)) | |||
felixmulder
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up logic of typedAssign, so that it now correctly handles the case
of an overloaded left-hand-side consisting of a provate[this] var
and one or more methods.