New bridge implementation #2342

DarkDimius · 2017-05-01T12:57:33Z

No description provided.

DarkDimius · 2017-05-01T18:45:18Z

@odersky, the first patch apparently doesn't break anything in our test-suite.

odersky · 2017-05-01T19:53:00Z

It turns out that bridges are severely undertested. In fact, we have an extensive test for bridges but it never made it out of pending. If I run the current implementation on this one I get:

Mix___eFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method Mix___eFoo__fwBar_I_.f()LBar_I_$I; is abstract
Mix___eFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method Mix___eFoo__fwBarYI_.f()LBarYI_$I; is abstract
Mix___eFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method Mix___eFoo_IfwBar___.f()Ljava/lang/Object; is abstract
Mix___eFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method Mix___eFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
Mix___eFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method Mix___eFooX_fwBar_I_.f()LBar_I_$I; is abstract
Mix___eFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method Mix___eFooX_fwBarYI_.f()LBarYI_$I; is abstract
Mix___eFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method Mix___eFooXIfwBar___.f()Ljava/lang/Object; is abstract
Mix___eFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method Mix___eFooXIfwBarY__.f()Ljava/lang/Object; is abstract
MixZ__eFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method MixZ__eFoo__fwBar_I_.f()LBar_I_$I; is abstract
MixZ__eFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method MixZ__eFoo__fwBarYI_.f()LBarYI_$I; is abstract
MixZ__eFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method MixZ__eFoo_IfwBar___.f()Ljava/lang/Object; is abstract
MixZ__eFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method MixZ__eFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
MixZ__eFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method MixZ__eFooX_fwBar_I_.f()LBar_I_$I; is abstract
MixZ__eFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method MixZ__eFooX_fwBarYI_.f()LBarYI_$I; is abstract
MixZ__eFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method MixZ__eFooXIfwBar___.f()Ljava/lang/Object; is abstract
MixZ__eFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method MixZ__eFooXIfwBarY__.f()Ljava/lang/Object; is abstract
Mix___wFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method Mix___wFoo__fwBar_I_.f()LBar_I_$I; is abstract
Mix___wFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method Mix___wFoo__fwBarYI_.f()LBarYI_$I; is abstract
Mix___wFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method Mix___wFoo_IfwBar___.f()Ljava/lang/Object; is abstract
Mix___wFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method Mix___wFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
Mix___wFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method Mix___wFooX_fwBar_I_.f()LBar_I_$I; is abstract
Mix___wFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method Mix___wFooX_fwBarYI_.f()LBarYI_$I; is abstract
Mix___wFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method Mix___wFooXIfwBar___.f()Ljava/lang/Object; is abstract
Mix___wFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method Mix___wFooXIfwBarY__.f()Ljava/lang/Object; is abstract
MixZ__wFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method MixZ__wFoo__fwBar_I_.f()LBar_I_$I; is abstract
MixZ__wFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method MixZ__wFoo__fwBarYI_.f()LBarYI_$I; is abstract
MixZ__wFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method MixZ__wFoo_IfwBar___.f()Ljava/lang/Object; is abstract
MixZ__wFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method MixZ__wFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
MixZ__wFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method MixZ__wFooX_fwBar_I_.f()LBar_I_$I; is abstract
MixZ__wFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method MixZ__wFooX_fwBarYI_.f()LBarYI_$I; is abstract
MixZ__wFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method MixZ__wFooXIfwBar___.f()Ljava/lang/Object; is abstract
MixZ__wFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method MixZ__wFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S_____eFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_____eFoo__fwBar_I_.f()LBar_I_$I; is abstract
S_____eFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_____eFoo__fwBarYI_.f()LBarYI_$I; is abstract
S_____eFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S_____eFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S_____eFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S_____eFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S_____eFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_____eFooX_fwBar_I_.f()LBar_I_$I; is abstract
S_____eFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_____eFooX_fwBarYI_.f()LBarYI_$I; is abstract
S_____eFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S_____eFooXIfwBar___.f()Ljava/lang/Object; is abstract
S_____eFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S_____eFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S__Z__eFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S__Z__eFoo__fwBar_I_.f()LBar_I_$I; is abstract
S__Z__eFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S__Z__eFoo__fwBarYI_.f()LBarYI_$I; is abstract
S__Z__eFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S__Z__eFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S__Z__eFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S__Z__eFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S__Z__eFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S__Z__eFooX_fwBar_I_.f()LBar_I_$I; is abstract
S__Z__eFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S__Z__eFooX_fwBarYI_.f()LBarYI_$I; is abstract
S__Z__eFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S__Z__eFooXIfwBar___.f()Ljava/lang/Object; is abstract
S__Z__eFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S__Z__eFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S_____wFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_____wFoo__fwBar_I_.f()LBar_I_$I; is abstract
S_____wFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_____wFoo__fwBarYI_.f()LBarYI_$I; is abstract
S_____wFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S_____wFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S_____wFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S_____wFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S_____wFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_____wFooX_fwBar_I_.f()LBar_I_$I; is abstract
S_____wFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_____wFooX_fwBarYI_.f()LBarYI_$I; is abstract
S_____wFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S_____wFooXIfwBar___.f()Ljava/lang/Object; is abstract
S_____wFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S_____wFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S__Z__wFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S__Z__wFoo__fwBar_I_.f()LBar_I_$I; is abstract
S__Z__wFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S__Z__wFoo__fwBarYI_.f()LBarYI_$I; is abstract
S__Z__wFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S__Z__wFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S__Z__wFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S__Z__wFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S__Z__wFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S__Z__wFooX_fwBar_I_.f()LBar_I_$I; is abstract
S__Z__wFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S__Z__wFooX_fwBarYI_.f()LBarYI_$I; is abstract
S__Z__wFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S__Z__wFooXIfwBar___.f()Ljava/lang/Object; is abstract
S__Z__wFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S__Z__wFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S_T___eFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_T___eFoo__fwBar_I_.f()LBar_I_$I; is abstract
S_T___eFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_T___eFoo__fwBarYI_.f()LBarYI_$I; is abstract
S_T___eFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S_T___eFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S_T___eFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S_T___eFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S_T___eFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_T___eFooX_fwBar_I_.f()LBar_I_$I; is abstract
S_T___eFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_T___eFooX_fwBarYI_.f()LBarYI_$I; is abstract
S_T___eFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S_T___eFooXIfwBar___.f()Ljava/lang/Object; is abstract
S_T___eFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S_T___eFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S_TZ__eFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_TZ__eFoo__fwBar_I_.f()LBar_I_$I; is abstract
S_TZ__eFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_TZ__eFoo__fwBarYI_.f()LBarYI_$I; is abstract
S_TZ__eFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S_TZ__eFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S_TZ__eFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S_TZ__eFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S_TZ__eFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_TZ__eFooX_fwBar_I_.f()LBar_I_$I; is abstract
S_TZ__eFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_TZ__eFooX_fwBarYI_.f()LBarYI_$I; is abstract
S_TZ__eFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S_TZ__eFooXIfwBar___.f()Ljava/lang/Object; is abstract
S_TZ__eFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S_TZ__eFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S_T___wFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_T___wFoo__fwBar_I_.f()LBar_I_$I; is abstract
S_T___wFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_T___wFoo__fwBarYI_.f()LBarYI_$I; is abstract
S_T___wFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S_T___wFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S_T___wFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S_T___wFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S_T___wFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_T___wFooX_fwBar_I_.f()LBar_I_$I; is abstract
S_T___wFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_T___wFooX_fwBarYI_.f()LBarYI_$I; is abstract
S_T___wFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S_T___wFooXIfwBar___.f()Ljava/lang/Object; is abstract
S_T___wFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S_T___wFooXIfwBarY__.f()Ljava/lang/Object; is abstract
S_TZ__wFoo__fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_TZ__wFoo__fwBar_I_.f()LBar_I_$I; is abstract
S_TZ__wFoo__fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_TZ__wFoo__fwBarYI_.f()LBarYI_$I; is abstract
S_TZ__wFoo_IfwBar___ raised exception java.lang.AbstractMethodError: Method S_TZ__wFoo_IfwBar___.f()Ljava/lang/Object; is abstract
S_TZ__wFoo_IfwBarY__ raised exception java.lang.AbstractMethodError: Method S_TZ__wFoo_IfwBarY__.f()Ljava/lang/Object; is abstract
S_TZ__wFooX_fwBar_I_ raised exception java.lang.AbstractMethodError: Method S_TZ__wFooX_fwBar_I_.f()LBar_I_$I; is abstract
S_TZ__wFooX_fwBarYI_ raised exception java.lang.AbstractMethodError: Method S_TZ__wFooX_fwBarYI_.f()LBarYI_$I; is abstract
S_TZ__wFooXIfwBar___ raised exception java.lang.AbstractMethodError: Method S_TZ__wFooXIfwBar___.f()Ljava/lang/Object; is abstract
S_TZ__wFooXIfwBarY__ raised exception java.lang.AbstractMethodError: Method S_TZ__wFooXIfwBarY__.f()Ljava/lang/Object; is abstract

96 errors

odersky · 2017-05-01T20:36:42Z

Rebased over #2331. I verified that with these changes (and the custom Either) the collection strawman now compiles and tests OK.

Those forwarders may disrupt method resolution.

This one is based on the way things are done in scalac. As yet missing: Systematic treatment of errors. Test i1240a was moved to pending. It caused a merge error before but this was likely accidental. We have to check whether systematic bridge error checking will discover a problem. For the moment the test behaves exactly as for scalac: it compiles and the result is the same.

Was info before, but signatures already contain all the information we need and are cheaper to test for equality.

odersky · 2017-05-01T21:48:17Z

Note: error diagnostic is still missing.

We were missing "has same signature after erasure" errors if the two methods in questions came from different parents.

smarter · 2017-05-02T12:41:19Z

compiler/src/dotty/tools/dotc/transform/ElimErasedValueType.scala

@@ -11,6 +11,9 @@ import TypeErasure.ErasedValueType, ValueClasses._
 /** This phase erases ErasedValueType to their underlying type.
 *  It also removes the synthetic cast methods u2evt$ and evt2u$ which are
 *  no longer needed afterwards.
+ *  Finally, it checks that we don't introduce "double definitions" of pairs


Why put this in ElimErasedValueType ? Shouldn't it be a separate mini-phase?

odersky · 2017-05-02T12:45:48Z

I knew you would say this 😀. There's some logic to put it here because at the end of ElimErasedValueTypes all denotations have the types that we need to check the condition. Creating lots of new phases has a cognitive cost as well.

smarter · 2017-05-02T12:51:39Z

I'll leave my vote for making a CheckDoubleDef phase just after ElimErasedValueType instead, and using Check as a prefix for all phases that do not change trees to make it easier to mentally filter them out. But I'll let you decide ;).

Fixed in scala#2342.

Fixed in scala#2342

odersky changed the title ~~Give to martin.y~~ [WIP] New bridge implementation May 1, 2017

odersky force-pushed the bridge branch from d9ea0a0 to 32b8e60 Compare May 1, 2017 20:34

DarkDimius and others added 6 commits May 1, 2017 23:44

Erasure: Don't generate forwarders to abstract members.

4cf4c4d

Those forwarders may disrupt method resolution.

Add one more testcase.

f6c9a66

Change println to debugLog statement

a48690b

Base decision whether to generate bridge on signatures

b9f1817

Was info before, but signatures already contain all the information we need and are cheaper to test for equality.

Remove now unused old implementation

2f7ac63

odersky force-pushed the bridge branch from 683a772 to 2f7ac63 Compare May 1, 2017 21:46

Report more double def errors

e4d530b

We were missing "has same signature after erasure" errors if the two methods in questions came from different parents.

smarter reviewed May 2, 2017

View reviewed changes

odersky requested a review from smarter May 2, 2017 13:08

odersky changed the title ~~[WIP] New bridge implementation~~ New bridge implementation May 2, 2017

smarter removed their request for review May 2, 2017 13:24

smarter assigned DarkDimius May 2, 2017

odersky merged commit 92fe2a5 into scala:master May 4, 2017

nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request May 5, 2017

Fixed scala#2202: Add regression test.

2d99927

Fixed in scala#2342.

nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request May 5, 2017

Fixed scala#2202: Add regression test.

5fd7503

Fixed in scala#2342

nicolasstucki mentioned this pull request May 5, 2017

Fixed #2202: Add regression test. #2376

Closed

allanrenucci deleted the bridge branch December 14, 2017 16:58

hamzaremmal mentioned this pull request Mar 2, 2025

Missing bridge method in trait when it has a covariant return type #22394

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New bridge implementation #2342

New bridge implementation #2342

Uh oh!

DarkDimius commented May 1, 2017

Uh oh!

DarkDimius commented May 1, 2017

Uh oh!

odersky commented May 1, 2017 •

edited

Loading

Uh oh!

odersky commented May 1, 2017

Uh oh!

odersky commented May 1, 2017

Uh oh!

smarter May 2, 2017

Uh oh!

odersky commented May 2, 2017

Uh oh!

smarter commented May 2, 2017

Uh oh!

Uh oh!

New bridge implementation #2342

New bridge implementation #2342

Uh oh!

Conversation

DarkDimius commented May 1, 2017

Uh oh!

DarkDimius commented May 1, 2017

Uh oh!

odersky commented May 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odersky commented May 1, 2017

Uh oh!

odersky commented May 1, 2017

Uh oh!

smarter May 2, 2017

Choose a reason for hiding this comment

Uh oh!

odersky commented May 2, 2017

Uh oh!

smarter commented May 2, 2017

Uh oh!

Uh oh!

odersky commented May 1, 2017 •

edited

Loading