Put -bin- in dotty version number #2301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to put "-bin" between the actual version number (0.1.X) and -SNAPSHOT or -XXX-NIGHTLY if we want sbt's scalaBinaryVersion to return 0.1. Unfortunately this is not enough: sbt will still return the full version number for versions less than 2.10, fixing this will require patching sbt, but it's good if we get the version number right already.
felixmulder
approved these changes
Apr 24, 2017
smarter
added a commit
to scala/scala3-example-project
that referenced
this pull request
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to put "-bin" between the actual version number (0.1.X) and
-SNAPSHOT or -XXX-NIGHTLY if we want sbt's scalaBinaryVersion to return
0.1. Unfortunately this is not enough: sbt will still return the full
version number for versions less than 2.10, fixing this will require
patching sbt, but it's good if we get the version number right already.