Try to avoid overconstraining when comparing and/or types #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comments in eitherIsSubType for an explanation what the problem is. Some test cases are in subtyping.scala
| class A { | ||
| def test1(): Unit = { | ||
| implicitly[this.type <:< this.type] | ||
| implicitly[this.type <:< A] |
There was a problem hiding this comment.
Why did you remove these tests?
|
LGTM. |
|
Thanks for the review! |
odersky
added a commit
that referenced
this pull request
Nov 18, 2014
Try to avoid overconstraining when comparing and/or types
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
May 8, 2025
Backport "Remove DRI from Scaladoc warnings" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @smarter