-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Avoid forcing infos of some symbols in InfoTransforms #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid forcing infos of some symbols in InfoTransforms #223
Conversation
Provides the "mayChange" hook to exclude symbols from being completed prior to a transformInfo.
@DarkDimius @smarter Can you check whether this fixes the CyclicReferences you were seeing in #200? |
Didn't help. I've changed a travis config to use JVM 1.8 in this branch. |
In fact, it did help! The cyclic reference occurs now somewhere else, when we try to find the abstract terms in RefChecks. I think what this hints at is that JDK 8 has some complex cyclic relationships which JDK 7 did not have, and which trigger the Cyclic Reference errors. I could not see anything obvious where we could avoid them in the stack trace yet. Will keep looking. But this seems to be a tough one. |
…assfileParser Another bit to help avoid CyclicReferences when reading Java classes
Should we switch to jdk8 for all branches? |
I guess so. If we say that our main platform is Java8 so we should test on it. |
On Thu, Nov 13, 2014 at 10:36 AM, Dmitry Petrashko <notifications@github.com
Martin Odersky |
The problem fixed in this PR shows that different JKDs could be used as to show errors in compiler. |
Avoid forcing infos of some symbols in InfoTransforms
Backport "In selector check, prefix of reference must match import qualifier" to 3.3 LTS
Provides the "mayChange" hook to exclude symbols from being completed
prior to a transformInfo.