Skip to content

Avoid forcing infos of some symbols in InfoTransforms #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2014

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 12, 2014

Provides the "mayChange" hook to exclude symbols from being completed
prior to a transformInfo.

Provides the "mayChange" hook to exclude symbols from being completed
prior to a transformInfo.
@odersky
Copy link
Contributor Author

odersky commented Nov 12, 2014

@DarkDimius @smarter Can you check whether this fixes the CyclicReferences you were seeing in #200?

@DarkDimius
Copy link
Contributor

Didn't help. I've changed a travis config to use JVM 1.8 in this branch.

@odersky
Copy link
Contributor Author

odersky commented Nov 13, 2014

In fact, it did help! The cyclic reference occurs now somewhere else, when we try to find the abstract terms in RefChecks. I think what this hints at is that JDK 8 has some complex cyclic relationships which JDK 7 did not have, and which trigger the Cyclic Reference errors. I could not see anything obvious where we could avoid them in the stack trace yet. Will keep looking. But this seems to be a tough one.

…assfileParser

Another bit to help avoid CyclicReferences when reading Java classes
@odersky
Copy link
Contributor Author

odersky commented Nov 13, 2014

Should we switch to jdk8 for all branches?

@DarkDimius
Copy link
Contributor

I guess so. If we say that our main platform is Java8 so we should test on it.
We can actually configure travis to use multiple jdk's. I propose to test both on java7 and java8. WDYT?

@odersky
Copy link
Contributor Author

odersky commented Nov 13, 2014

On Thu, Nov 13, 2014 at 10:36 AM, Dmitry Petrashko <notifications@github.com

wrote:

I guess so. If we say that our main platform is Java8 so we should test on
it.
We can actually configure travis to use multiple jdk's. I propose to test
both on java7 and java8. WDYT?

As long as Travis lets us, this is an option. But since we will generate
code for Java 8 only, why test on Java 7?

  • Martin


Reply to this email directly or view it on GitHub
#223 (comment).

Martin Odersky
EPFL

@DarkDimius
Copy link
Contributor

The problem fixed in this PR shows that different JKDs could be used as to show errors in compiler.

DarkDimius added a commit that referenced this pull request Nov 15, 2014
Avoid forcing infos of some symbols in InfoTransforms
@DarkDimius DarkDimius merged commit c82a4b5 into scala:master Nov 15, 2014
@allanrenucci allanrenucci deleted the fix/elimRepeatedTransformSym branch December 14, 2017 19:22
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request May 8, 2025
Backport "In selector check, prefix of reference must match import qualifier" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants