Skip to content

Scopes: make sure every bucket of the hash table is used #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2014

Conversation

smarter
Copy link
Member

@smarter smarter commented Nov 11, 2014

Previously, one bucket was never used because in binary,
12*2^n - 1 = 101111...

Review by @odersky @namin .

Previously, one bucket was never used because in binary,
12*2^n - 1 = 101111...
@smarter
Copy link
Member Author

smarter commented Nov 11, 2014

By the way, Scopes.scala seems to have some vestigial comments and code, the description of MutableScope says:

Note: constructor is protected to force everyone to use the factory methods newScope or newNestedScope instead.
This is necessary because when run from reflection every scope needs to have a
SynchronizedScope as mixin.

But SynchronizedScope does not exist in Dotty.
Similarly, the method newNestedScope is never used.

odersky added a commit that referenced this pull request Nov 11, 2014
Scopes: make sure every bucket of the hash table is used
@odersky odersky merged commit b164b6d into scala:master Nov 11, 2014
@odersky
Copy link
Contributor

odersky commented Nov 11, 2014

LGTM

WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request May 8, 2025
Backport "fix: record calls to constructors in lambdaLift" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants