checkNoPrivateLeaks: Do not allow types to refer to leaky aliases #2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not going to be checked in the CI until we fix the signage issue of |
|
What issue? Do I just need to resign the .drone.yml? |
|
Yes, that looks like it's the issue. |
|
I'm not sure why - maybe it was how/because we restarted the server. |
|
Nope, when I resign it, it's identical to the existing one. |
|
Put this: |
|
@felixmulder You should be able to push to this branch an extra commit with that. |
|
Or even better, make a separate PR and merge if the tests start. |
|
Hmm, I had a slight modification to my But anyway, let's try to fix this using IM. |
|
Fixed by restarting drone. |
|
Hooray, we did it! |
`checkNoPrivateLeaks` can force a lot of things, this lead to hard-to-reproduce issues in unpickling because we called `checkNoPrivateLeaks` on the type parameters of a class before anything in the class was indexed. We fix this by making sure that `checkNoPrivateLeaks` never transforms type symbols, only term symbols, therefore we can unpickle type parameters without forcing too many things. tests/neg/leak-type.scala illustrates the new restriction that this necessitates.
smarter
force-pushed
the
fix/privateleak-forcing
branch
from
552cb55 to
6ae376a
Compare
odersky
approved these changes
Apr 4, 2017
|
@smarter that fixed it! Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkNoPrivateLeakscan force a lot of things, this lead tohard-to-reproduce issues in unpickling because we called
checkNoPrivateLeakson the type parameters of a class before anythingin the class was indexed. We fix this by making sure that
checkNoPrivateLeaksnever transforms type symbols, only term symbols,therefore we can unpickle type parameters without forcing too many
things.
tests/neg/leak-type.scalaillustrates the new restriction thatthis necessitates.
@OlivierBlanvillain Can you confirm that this fixes the issue for you too?