Fix documentation in Iterable.scala #21692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for zipAll is incorrect, e.g., List(1, 2, 3).zipAll(Set("x"), 0, "") produces a list, not a set.
sjrd
approved these changes
Oct 2, 2024
|
We should also port the change to the scala/scala repository here. @charpov would you like to do it or should I open a PR? |
|
I signed the CLA. |
Great, thanks !
Sure no worries. I will open one and ping you there. |
hamzaremmal
added a commit
to hamzaremmal/scala2
that referenced
this pull request
Oct 4, 2024
Originally submitted in scala/scala3#21692 Co-authored-by: Michel Charpentier <charpov@users.noreply.github.com>
SethTisue
pushed a commit
to hamzaremmal/scala2
that referenced
this pull request
Oct 22, 2024
Originally submitted in scala/scala3#21692 Co-authored-by: Michel Charpentier <charpov@users.noreply.github.com>
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
Originally submitted in scala#21692 Co-authored-by: Michel Charpentier <charpov@users.noreply.github.com>
hamzaremmal
added a commit
that referenced
this pull request
May 7, 2025
Originally submitted in #21692 Co-authored-by: Michel Charpentier <charpov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
zipAllis incorrect, e.g.,List(1, 2, 3).zipAll(Set("x"), 0, "")produces a list, not a set.