Remove dead code in pattern matching #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
suggested changes
Mar 30, 2017
| protected def seqTree(binder: Symbol) = tupleSel(binder)(firstIndexingBinder + 1) | ||
| protected def tupleSel(binder: Symbol)(i: Int): Tree = { | ||
| private def seqTree(binder: Symbol): Tree = | ||
| if (firstIndexingBinder == 0) ref(binder) |
There was a problem hiding this comment.
this isn't a refactoring, why did you need this change?
There was a problem hiding this comment.
It's overriden in the only trait instance https://github.com/lampepfl/dotty/pull/2157/files#diff-b72950e41046b80e7386c4936d560cf9L1611
| def resultInMonad = | ||
| if (aligner.isBool) defn.UnitType | ||
| else if (isProductMatch(resultType, aligner.prodArity)) resultType | ||
| else if (isGetMatch(resultType)) extractorMemberType(resultType, nme.get) | ||
| else resultType | ||
|
|
||
| def resultType: Type | ||
|
|
||
| /** Create the TreeMaker that embodies this extractor call |
There was a problem hiding this comment.
it would be nice to preserve documentation
OlivierBlanvillain
force-pushed
the
patmat-dead-code
branch
from
5107c89 to
fe4974c
Compare
|
Alright, removed the 3rd commit. |
DarkDimius
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This entry point to pattern matching is apparently unreachable.
tupleExtractorwhich in also unreachable in dotty.