Fix #2064: Avoid illegal types in OrDominator #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to skip type bounds in `underlying` chain, since TypeBounds is not a legal operand type for OrType.
|
Review by @gsps? |
`superType` should never return a `TypeBounds` in the first place. This commit makes sure it doesn't.
|
@gsps To find out what the typer does, it's sometimes helpful to compile with |
smarter
reviewed
Mar 8, 2017
| @@ -1276,7 +1276,10 @@ object Types { | |||
| * except for TypeRefs where the upper bound is returned, and HKApplys, | |||
There was a problem hiding this comment.
This comment is no longer accurate since this isn't limited to TypeRef anymore, right?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to skip type bounds in
underlyingchain, sinceTypeBounds is not a legal operand type for OrType.
Fixes #2064