Skip to content

Bring back ambiguity filter when we report an implicit not found #20367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion compiler/src/dotty/tools/dotc/typer/Typer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4113,7 +4113,14 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer
* `SearchFailureType`.
*/
def issueErrors(fun: Tree, args: List[Tree]): Tree =
def firstFailure = args.tpes.find(_.isInstanceOf[SearchFailureType]).getOrElse(NoType)
// Prefer other errors over ambiguities. If nested in outer searches a missing
// implicit can be healed by simply dropping this alternative and tryng something
// else. But an ambiguity is sticky and propagates outwards. If we have both
// a missing implicit on one argument and an ambiguity on another the whole
// branch should be classified as a missing implicit.
val firstNonAmbiguous = args.tpes.find(tp => tp.isError && !tp.isInstanceOf[AmbiguousImplicits])
def firstError = args.tpes.find(_.isInstanceOf[SearchFailureType]).getOrElse(NoType)
def firstFailure = firstNonAmbiguous.getOrElse(firstError)
val errorType =
firstFailure match
case tp: AmbiguousImplicits =>
Expand Down
40 changes: 40 additions & 0 deletions tests/run/i20354.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
trait CmdLineParser { outer =>

trait Opt[+T] {
val default: T
val names: Set[String]
val help: String
}

trait IntOpt extends Opt[Int] {
val parser = outer // <=== comment out this line, we get "true true"
}
}

object FirstParser extends CmdLineParser {
object OptMinSuccess extends IntOpt {
val default = 100
val names = Set("bla")
val help = "bla"
}

val opts = List(OptMinSuccess)
}

object SecondParser extends CmdLineParser {
object OptMinSuccess extends IntOpt {
val default = 50
val names = Set("bla")
val help = "help"
}
}
@main def Test =

val a = SecondParser.OptMinSuccess.isInstanceOf[FirstParser.IntOpt]

println(a)

(SecondParser.OptMinSuccess: SecondParser.IntOpt) match {
case _: FirstParser.IntOpt => println("true")
case _ => println("false")
}
Loading