Make resolveSuper less slow #2017
Conversation
By ordering tests in a smarter way. Add leave a big scary comment.
| @@ -40,6 +40,12 @@ class MixinOps(cls: ClassSymbol, thisTransform: DenotTransformer)(implicit ctx: | |||
| def isCurrent(sym: Symbol) = | |||
| ctx.atPhase(thisTransform) { implicit ctx => | |||
| cls.info.member(sym.name).hasAltWith(_.symbol == sym) | |||
| // this is a hot spot, where we spend several seconds while compiling stdlib | |||
| // unfortunately it will discard and recompute all the member chaches, | |||
|
For comparison, here are timings from dotty boostrap (warm, 4th iteration), before the change in this PR. [frontend in 8788ms] [sbt-deps in 0ms] [posttyper in 507ms] [sbt-api in 0ms] [pickler in 872ms] [TreeTransform:{firstTransform, checkReentrant} in 157ms] [TreeTransform:{refchecks, checkStatic, elimRepeated, normalizeFlags, extmethods, expandSAMs, tailrec, liftTry, classOf} in 991ms] [TreeTransform:{tryCatchPatterns, patternMatcher, explicitOuter, explicitSelf, shortcutImplicits, crossCast, splitter} in 921ms] [TreeTransform:{vcInlineMethods, isInstanceOfEvaluator, seqLiterals, intercepted, getters, elimByName, augmentScala2Traits, resolveSuper, primitiveForwarders, arrayConstructors} in 835ms] [erasure in 1631ms] [TreeTransform:{elimErasedValueType, vcElideAllocations, mixin, LazyVals, memoize, linkScala2ImplClasses, nonLocalReturns, capturedVars, constructors, functionalInterfaces, getClass} in 643ms] [TreeTransform:{lambdaLift, elimStaticThis, flatten, restoreScopes} in 476ms] [TreeTransform:{expandPrivate, selectStatic, collectEntryPoints, collectSuperCalls, dropInlined, moveStatic, labelDef} in 414ms] [genBCode in 3912ms] |
For the comparison to be fair, you should run with |
By reordering tests and performing cheaper ones first.