Change 'is abstract; cannot be instantiated' to Message #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
reviewed
Feb 22, 2017
| val kind = "Usage" | ||
| private val traitOrAbstract = if (isTrait) hl"a trait" else hl"abstract" | ||
| val msg = hl"""${cls.name} is ${traitOrAbstract}; it cannot be instantiated""" | ||
| val explanation = "" |
There was a problem hiding this comment.
Perhaps an explanation here to say you can use:
new TraitName { }To instantiate it?
There was a problem hiding this comment.
But of course using the actual symbol name..
There was a problem hiding this comment.
Yes, could be good.
I thought of mentioning the object TraitName extends TraitName pattern which is quite common.
|
Great! Thanks @ennru 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@felixmulder
Next error to the case class scheme. Called its kind "Usage Error" - maybe the error kinds should be defined.