Change 'overrides nothing' to report via Message (see #1965) #1968
Conversation
|
|
||
| assertMessageCount(1, messages) | ||
| val OverridesNothing(member) :: Nil = messages | ||
| assertEquals("bar", member.name.toString) |
There was a problem hiding this comment.
member.name.toString => member.name.show
There was a problem hiding this comment.
Doesn't really matter in this case, but show automatically decodes "weird" names - so let's set a good precedence 👍
There was a problem hiding this comment.
Ah, than I reckon I should use member.name.show in the message and explanation, as well - or does hl do that for me?
There was a problem hiding this comment.
hl should do that for you
| val nonMatching = clazz.info.member(member.name).altsWith(alt => alt.owner != clazz && !alt.is(Final)) | ||
| def issueError(suffix: String) = | ||
| ctx.error(i"$member overrides nothing$suffix", member.pos) | ||
| val nonMatching = clazz.info.member(member.name).altsWith(alt => alt.owner != clazz) |
There was a problem hiding this comment.
Just looking at the compressed diff here - so I can't see the reason to cut !alt.is(Final)
There was a problem hiding this comment.
The former error message listed only non-final methods with the same name, but I think it is useful to have even final methods in the "not eligible" list of methods so that one can easily see it as the modifiers are included.
| // check expected context data | ||
| assertEquals("bar", member.name.toString) | ||
| assertEquals(3, sameName.size) | ||
| assert(sameName.forall(_.symbol.name.toString == "bar"), |
| assertMessageCount(1, messages) | ||
| val OverridesNothingButNameExists(member, sameName) :: Nil = messages | ||
| // check expected context data | ||
| assertEquals("bar", member.name.toString) |
|
Regarding |
|
Thanks @ennru! 🎉 |
'overrides nothing' is now reported as Message as descibed in #1589 (even though it is not listed in that issue.
I took the liberty to split the error into two different messages:
Please review the explaining texts thoroughly as I'm not really sure what to call things properly.
I noticed
SingleDenotation.showDclcreates non-valid code e.g.def foo(i: Int)Unitwithout the colon. Is there a better way to print declarations in the error messages?