Fix #1965: add proper testing infrastructure for reporting tests #1966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
added
area:reporting
OlivierBlanvillain
suggested changes
Feb 10, 2017
| } | ||
| } | ||
|
|
||
| ctx = freshReporter(ctx) |
There was a problem hiding this comment.
I would move the mutation stuff at the very top of the trait. BTW could you make it a class instead? (it feels wrong to have class → trait → class inheritance)
There was a problem hiding this comment.
Maybe DottyTest should be a trait instead?
| f(ictx, messages) | ||
| } | ||
|
|
||
| def expectNoErrors: Unit = this.isInstanceOf[FailedReport] |
There was a problem hiding this comment.
Did you mean asInstanceOf?
There was a problem hiding this comment.
No, but I should probably rename FailedReport => EmptyReport
There was a problem hiding this comment.
Then I don't understand the statement, this computes a Boolean and converts it to Unit regardless of it's value?
| rep | ||
| } | ||
|
|
||
| def messageCount(expected: Int, messages: List[Message]): Unit = |
There was a problem hiding this comment.
assertMessageCount
|
Looks good otherwise :) |
felixmulder
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 10, 2017
felixmulder
force-pushed
the
topic/error-messages-unit-tests
branch
from
21bc19e to
3d20e9d
Compare
felixmulder
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 10, 2017
OlivierBlanvillain
approved these changes
Feb 10, 2017
felixmulder
force-pushed
the
topic/error-messages-unit-tests
branch
from
3d20e9d to
07384ca
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.