The dotty-bot #1963
Merged
The dotty-bot #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
force-pushed
the
topic/dotty-bot
branch
from
13788d1 to
7754417
Compare
|
Shouldn't it be compiled and tested by the CI? |
|
Also, as much as I like mono-repositories, this is completely separate from dotty and could be its own project really. |
felixmulder
force-pushed
the
topic/dotty-bot
branch
from
7754417 to
45e7aa8
Compare
|
It should indeed! Whether or not it should be a part of the mono-repo, I'll leave that up to discussion here. Since it's its own separate sbt-project, it shouldn't be bothersome for the rest of the project, and improvements will be noticed by contributors. Going to sleep some more on it, cheers Felix |
OlivierBlanvillain
approved these changes
Feb 13, 2017
bot/resources/test-pr.json
Outdated
| @@ -0,0 +1,432 @@ | |||
| { | |||
There was a problem hiding this comment.
This should be in src/test/resources
This PR will add a bot whose first purpose is to check the CLA of contributing PRs. It improves on the old bot in that it checks each commit individually, and doesn't get upset about 100+ commits. It would be fun to do this PR with you @OlivierBlanvillain, feel free to provide feedback/comments and refactor as you like
felixmulder
force-pushed
the
topic/dotty-bot
branch
from
037d664 to
b760a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bot is meant to be our new build automation hero. Currently it does the CLA checking of all commits (both commiters and authors), there's no restriction on X commits, it handles the pagination gracefully.
With this merged, I can tell Fabien to host it for us so that we can snip the cord to the old CI infra for good.