Improve MiMa failure error message #19613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it tells which filer list is related to this test
Extract the Scala 2 library bootstrapped breaking changes into a separate file. These are not that important, there we care more about the TASTy MiMa. This makes it simpler to read and maintain the MiMaFilters. Also some renaming to make the semantics of the lists more explicit.
nicolasstucki
force-pushed
the
improve-mima-reporting
branch
from
7a3fc22 to
7fb1d8b
Compare
nicolasstucki
commented
Feb 5, 2024
| mimaReportBinaryIssues.result.value match { | ||
| case Inc(inc: Incomplete) => | ||
| streams.value.log.error(s"\nFilers in $issueFilterLocation are used in this check.\n ") | ||
| throw inc |
There was a problem hiding this comment.
I am not sure if there is a cleaner way to do this.
sjrd
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it tells which filer list is related to this test. Change suggested by @odersky.
Example failure:
More documentation is available in
MiMaFilters.Scala3Library.Refactored filter lists to strengthen TastyCore and Interfaces to use separate backward and forwards lists. Also extracted the Scala2LibraryBootstrappedMiMaFileters to reduce noise in the MiMaFilter files.