Detect cycles involving types bounded by singleton types #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Ping, I can't merge this or #180 myself because I'm not a member of https://github.com/lampepfl/ . |
|
This one should be rebased on current master. It doesn't merge. |
smarter
force-pushed
the
fix/singleton-cycles
branch
from
f70a7ea to
3d6534f
Compare
|
Rebased. |
odersky
added a commit
that referenced
this pull request
Nov 9, 2014
Detect cycles involving types bounded by singleton types
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
May 8, 2025
Backport "Suppress spurious Suppression" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #193, but I don't know if it breaks other things :).
Review by @odersky @DarkDimius @namin .