Fix classpaths in dottydoc tests #1937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the test hangs, as well as other ci run today. |
|
Seems like this passed our CI now? The |
liufengyun
reviewed
Feb 3, 2017
doc-tool/test/MarkdownTests.scala
Outdated
| @@ -6,6 +6,7 @@ import org.junit.Assert._ | |||
|
|
|||
| import dotc.core.Contexts.{ Context, ContextBase, FreshContext } | |||
| import dotc.core.Comments.{ ContextDoc, ContextDocstrings } | |||
| import java.io.{ File => JFile } | |||
There was a problem hiding this comment.
It seems this import is not used.
|
Otherwise, LGTM |
felixmulder
force-pushed
the
fix/classpath-dottydoc-tests
branch
from
d7812e2 to
0f59e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #1934