Fix #1568 - avoid transforming error trees #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a tree has type error, subtrees may not have an assigned type. Therefore we should avoid transforming such trees.
| @@ -573,6 +573,8 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo { | |||
| Try(tree: Tree)(expr, cases, finalizer) | |||
| } | |||
|
|
|||
| override def skipTransform(tree: Tree)(implicit ctx: Context) = tree.tpe.isError | |||
There was a problem hiding this comment.
It might be cleaner to just override the transform as follows:
override def transform(tree: Tree)(implicit ctx: Context): Tree =
if (tree.tpe.isError) tree else super.transform(tree)There was a problem hiding this comment.
I was debating what was simpler, and more efficient. I also first thought of overriding transform, but: (1) this requires a new TreeMap class in tpd (2) this adds a stackframe to each node traversal, which can add up. So I think the current approach is more lightweight in the end.
|
Otherwise it LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tree has type error, subtrees may not have an assigned type.
Therefore we should avoid transforming such trees.