Fix subtyping checks involving ThisType and PolyParam #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/ThisType-subtyping
branch
2 times, most recently
from
0c2ba3c to
f731d22
Compare
|
Using widenExpr fixes the problem and doesn't break any test. |
smarter
force-pushed
the
fix/ThisType-subtyping
branch
from
f731d22 to
629dae0
Compare
|
LGTM |
odersky
added a commit
that referenced
this pull request
Nov 11, 2014
Fix subtyping checks involving ThisType and PolyParam
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 8, 2016
Structural calls should be faster thanks to method caching. Fixed issue scala#192.
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
Structural calls should be faster thanks to method caching. Fixed issue scala#192.
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
May 8, 2025
Backport "Fix SeparateCompilationSource toString" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if the problem occurs with other types than ThisType or if there's a cleaner fix.
Review by @odersky @DarkDimius @namin .