constructors & getters-setters #189
Conversation
Use ref and appliedTo instead.
The idea to traverse with currently enclosing methid is also used in LambdaLift and could be used elsewhere.
…lled. Instead of requiring to be called a given phase, change the context if that is not the case.
Lifting an application `f(arg1).f(args)` requires lifting of the whole prefix `f(arg1)`, because `f` might have a side effect.
Advantage: Can rename typed as well as untyped trees.
Previously, we determined the default getters solely from the method TermRef type. This is wrong if the method is prefix is not a path -- the prefix of the term ref will be a TypeRef and the getter selection will be a SelectFromType tree, which makes no sense.
It changes meaning drastically so should always be visible.
Some transformations encounter applications where new arguments ahve to be supplied. The method type already accounts for these argument but the Application node passed into TreeTransform#transformApply is constructed with a cpy.Apply operation which does a type assignment. That type assignment fails with a parameter mismatch unless relaxedTyping is on.
Environment parameters do not count in th eresult type.
The current formulation of lambda lift is easier to do if that's the case.
Need to drop all non-class type declarations.
Params are already added by Desugar. No special treatment needed here. Besides primaryConstructor.typeParams is always empty, because term symbols do not have type parameters. The fix turns t2660.scala into an error. I believe the error is correct, hence the test was moved with a comment to neg.
Primary constructor was picking last constructor instead of first one. This is now fixed. Also, added paramAccessors utility method.
Needed to fix a problem in CapturedVars to make this work.
Like the corresponding parameters, these also need to be rewritten to function types.
1) Type parameters are now copied to accessors 2) Constructors also work for traits 2) makes it possible do to mixin after constructors.
TypeVars can appear as keys in baseType caches. The problem is that their base types depend on their instantiation, which is not always know yet when the test is performed. So results of baseType on type variables should never be cached. Todo: check whether there are any other caching problems involving typevars.
Typevars can be parts of larger types or underlying types of other types, which renders these other types uncacheable. The new logic takes account of that.
Private fields that are accessed only from the constructor, and are accessed only after they are properly initialized are now moved into the constructor. This avoids creating a redundant objetc field. Good example: gcd in Rationals (see constrs.scala).
TypeVar is a TypeProxy.
Allow to skip labels.
…ories. We better make this configurable. Because sometimes we want to compile only the files in the immediate directory.
When using RefinedPrinter we now have a choice whether when
printing a definition tree such as
def foo(x: T): U
we print the parameter and result type info found in the tree or in the symbol.
Previously, we printed the sym info when after typer and the tree info before.
This turns out to be too inflexble. With the patch, we print the sym info if
option -Yprint-syms is set, and the tree info otherwise.
Also, align -Yno-deep-subtypes from camelCase to standard hyphenated option notation.
Tweak where unique ids are printed.
In scalac SubstOnlyTreeMakers were implemented using substitution, and didn't actually introduce new trees. Thus there was an optimization to remove them while generating code. This optimization led to scala#190. It is now removed.
|
I'm having a look if LabmdaLift failure for |
|
OK thanks! - Martin On Mon, Oct 13, 2014 at 1:08 PM, Dmitry Petrashko notifications@github.com
Martin Odersky |
|
It looks like the pattern matcher generates another symbol without definition. This time it's "o51". I have enhanced the LambdaLifter to give better error messages in case something like this happens. |
|
Note that breaks dotc_core even if LambdaLift is disabled. |
|
More investigation shows that fails with an error Exception in thread "main" java.lang.AssertionError: assertion failed: error at Types.scala:2633 |
given a pattern
object b
x match {
case y @ b => <body>
}
y inside the <body> `y` should have type b.type.
Inherited from scalac EqualityTestTreeMaker would reset type of it
in order to achive this.
Dotty instead needs to know this in advance.
|
@odersky. Should be fixed now. |
|
It's not fixed. It breaks for more complicated patterns, I'm investigating. |
|
Ok, i've found what causes an error. it creates a tree that given current decoding scheme means I can make a quickfix by just ignoring structure Bind(_, Typed(Unapply)). |
Substitution was creating more problems than solving. Instead the symbols in tree aren't rewriten anymore, and pattern matcher collects Rebindings and generates ValDefs for them just before the guard & body of the generated case.
Typer creates a tree that given current decoding scheme means case a @ (Assign(Ident(id), rhs) : tpt) Which isn't valid scala.
|
On Mon, Oct 13, 2014 at 6:42 PM, Dmitry Petrashko notifications@github.com
More precisely we'd like to be in a position where after type-checking assignType(tree @ Typed(unapp: Unapply, tpt) = That rule should be added. Without the Typed around the Unapply, assigning Cheers
Martin Odersky |
After erasure, asInstanceworks only bedtween reference types, so erasure is not allowed to insert asInstanceOfs between numeric types. Previously this made t1260 fail even if LambdaLift is disabled.
to get a working baseline build
|
@odersky I propose to merge this PR. WDYT? |
|
Yes, LGTM |
constructors & getters-setters
Backport "fix: hover and go to definition for named tuples" to 3.3 LTS
Same as #187
This branch has the same code as in #186 but has a lot cleaner history.
Difference is several additional tests that were somehow lost in #186 and ElimLocals and Flatten being in
transformpackage