Bump version from 0.1-SNAPSHOT to 0.1.1-SNAPSHOT #1888
Conversation
This is useful for two reasons: - All published Scala versions are of the form a.b.c and some tooling expect that, like sbt CrossVersion API. - Using 0.1.1 instead of 0.1.0 means that we match the version number of dotty-sbt-bridge, this is simpler and means that in the future sbt could automatically choose the correct version of dotty-sbt-bridge so that the user does not need to specify scalaCompilerBridgeSource in his build.sbt Note: it's awful that we have hardcoded paths to jars and that I had to change them, but I won't fix that now.
|
Do we have another option when it comes to the jars? I'd love to get rid of it. Martin doesn't like them either :) Will have a closer look in the morning! Cheers, |
|
Get them from sbt, it's the only sane thing to do, and what I plan to do on my sbt-based bootstrapping branch (I need to do it, since the jars are different depending on whether I'm running dotty-compiled-by-scala2 or dotty-bootstrapped) |
|
Once this PR is in I'll make a PR to sbt to have automatic |
| "0.1.1-" + VersionUtil.commitDate + "-" + VersionUtil.gitHash + "-NIGHTLY" | ||
| else | ||
| "0.1.1-SNAPSHOT" | ||
| }, |
There was a problem hiding this comment.
When publishing nightlies we run NIGHTLYBUILD=yes sbt ... and thus L419 is used as the value of version. What was the reason for removing this?
There was a problem hiding this comment.
Because it now uses the global version set above.
There was a problem hiding this comment.
You mean baseVersion? If so, won't the resulting jars from snapshot publish drop SNAPSHOT from the artefact name? Also, perhaps more importantly - how do you publish nightlies with the hash and commit date?
There was a problem hiding this comment.
This is all done in the global settings: https://github.com/dotty-staging/dotty/blob/0bca6b76ee6c7c9555707d03551593dd04b5fe81/project/Build.scala#L49
There was a problem hiding this comment.
Previously this was done differently in dotty-sbt-bridge because of its different versioning scheme, now we can use the same version setting as dotty for dotty-sbt-bridge
There was a problem hiding this comment.
Ah I see, it was previously duplicated. Cool, then LGTM!
This is useful for two reasons:
expect that, like sbt CrossVersion API.
dotty-sbt-bridge, this is simpler and means that in the future sbt
could automatically choose the correct version of dotty-sbt-bridge so
that the user does not need to specify scalaCompilerBridgeSource in
his build.sbt
Note: it's awful that we have hardcoded paths to jars and that I had to
change them, but I won't fix that now.
Review by @felixmulder