Fix dummy scala-library #1885
Merged
Fix dummy scala-library #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be useful, the dummy scala-library: - needs to be published with crossPaths off (the "_2.11" path of the artefact name), like the real scala-library - should depend on dotty-library and not just scala-library, since this is what is needed to compile dotty programs
felixmulder
approved these changes
Jan 6, 2017
|
LGTM 🎉 |
smarter
added a commit
to scala/scala3-example-project
that referenced
this pull request
Jan 8, 2017
No longer necessary after scala/scala3#1885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be useful, the dummy scala-library:
artefact name), like the real scala-library
is what is needed to compile dotty programs
Review by @felixmulder