Skip to content

Fix warning underlining in global init checker #18668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix warning underlining in global init checker #18668

merged 2 commits into from
Oct 10, 2023

Conversation

q-ata
Copy link
Contributor

@q-ata q-ata commented Oct 9, 2023

Fixes the placement of the caret when the global init checker reports warnings for multi-line statements.

@q-ata
Copy link
Contributor Author

q-ata commented Oct 10, 2023

This fixes #18625

olhotak
olhotak approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olhotak olhotak merged commit e1b5451 into scala:main Oct 10, 2023
@olhotak olhotak deleted the fix-global7 branch October 10, 2023 13:34
@olhotak olhotak mentioned this pull request Oct 10, 2023
Closed
@liufengyun liufengyun mentioned this pull request Nov 6, 2023
Closed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olhotak olhotak olhotak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@q-ata @olhotak @Kordyjan