-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Topic/syntax spec docs #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/syntax spec docs #1849
Conversation
I purposefully reengineered the history to make it possible to review the changes. Of course I will squash the commits later to eventually merge. |
Awesome! You should also add a link to it from https://github.com/lampepfl/dotty/blob/master/docs/docs/index.md, also the tex version should be deleted to avoid duplication. |
Ah, one thing I was not sure about: I deleted the tree annotations that can be found in the tex version, like -| Refinement RefinedTypeTree(EmptyTree, refinement)
+| Refinement Not sure, whether you want to keep them. |
Looks great. Definitely better to have this in markdown. I would leave the tree annotations in this version of the document, though. The reason is that they give us a good overview what parsed constructs map into. When we export the document to a language spec, they would be removed, of course. |
LGTM, Thanks! |
This PR ports the syntax spec from this tex document to Markdown and fixes a couple of typos and minor bugs.
@smarter What do you think?