don't disable all scalacOptions, only Ysafe-init and Xcheck-macros #18268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck-macros In the community build runner, comments for the shapeless and protoquill projects say to disable the Ysafe-init and Xcheck-macros options, but the implementation disables all scalacOptions. This change makes the implementation match the comments. Also, the comment for protoquill incorrectly stated that Ysafe-init needs to be disabled due to a buggy macro. The project works fine with Ysafe-init, but the buggy macro requires Xcheck-macros disabled.
nicolasstucki
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the community build runner, comments for the shapeless and protoquill projects say to disable the Ysafe-init and Xcheck-macros options, but the implementation disables all scalacOptions. This change makes the implementation match the comments.
Also, the comment for protoquill incorrectly stated that Ysafe-init needs to be disabled due to a buggy macro. The project works fine with Ysafe-init, but the buggy macro requires Xcheck-macros disabled.