Fix #1820: make sure outer of traits implemented #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
fix-i1820
branch
from
72bbc30 to
3f5a573
Compare
Previously, we don't generate `outer` for the anonymous class `new Inner2 {}`.
This is incorrect, as `Inner2 {}` extends `A.Inner`, which requires an outer.
trait A {
val a = "a"
trait Inner {
def f = println(a)
def h = 3
}
}
trait B extends A {
trait Inner2 extends Inner
new Inner2 {}
}
liufengyun
force-pushed
the
fix-i1820
branch
from
3f5a573 to
bfabcee
Compare
liufengyun
changed the title
odersky
reviewed
Dec 20, 2016
| @@ -81,14 +81,19 @@ class ExplicitOuter extends MiniPhaseTransform with InfoTransformer { thisTransf | |||
| !needsOuterAlways(cls) && | |||
| impl.existsSubTree(referencesOuter(cls, _))) | |||
| ensureOuterAccessors(cls) | |||
| if (hasOuter(cls)) { | |||
|
|
|||
| val hasOuterFlag = hasOuter(cls) | |||
There was a problem hiding this comment.
Can we rename hasOuterFlag to clsHasOuter, or something like this?
I was reading hasOuterFlag as "has the Outer flag set" but of course there is no such flag.
Otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1820: make sure outer of traits implemented.
Review @DarkDimius