Fix #1802: Make sure errors are not swept under the carpet #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typer#ensureReported's comment outlines an example where errors could go unreported, resulting in error trees after typer without any reported error messages. This commit makes sure that at least one error is reported if a tree node has an error type. Fixes scala#1802.
smarter
reviewed
Dec 17, 2016
| @@ -3251,12 +3252,16 @@ object Types { | |||
| override def computeHash = hashSeed | |||
| } | |||
|
|
|||
| abstract class ErrorType extends UncachedGroundType with ValueType | |||
| abstract class FlexType extends UncachedGroundType with ValueType | |||
There was a problem hiding this comment.
Could you add some documentation on the meaning of FlexType?
|
This looks like Printers.cyclicErrors is on? (i.e. set to new Printer). In
that case the error message is normal. It should be set to noPrintter by
default, though.
…On Sat, Dec 17, 2016 at 4:09 PM, Guillaume Martres ***@***.*** > wrote:
***@***.**** commented on this pull request.
------------------------------
In compiler/src/dotty/tools/dotc/core/Types.scala
<#1817 (review)>:
> @@ -3251,12 +3252,16 @@ object Types {
override def computeHash = hashSeed
}
- abstract class ErrorType extends UncachedGroundType with ValueType
+ abstract class FlexType extends UncachedGroundType with ValueType
Could you add some documentation on the meaning of FlexType?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1817 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwlVgMZmd3tOJ_ArnQK-xIMhRoTzdsSks5rI_szgaJpZM4LP5SD>
.
{"api_version":"1.0","publisher":{"api_key":"
05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":
{"external_key":"github/lampepfl/dotty","title":"
lampepfl/dotty","subtitle":"GitHub repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-
11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://
cloud.githubusercontent.com/assets/143418/15842166/
7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/lampepfl/dotty"}},"
***@***.*** commented on
#1817"}],"action":{"name":"View Pull Request","url":"https://
github.com/lampepfl/dotty/pull/1817#pullrequestreview-13447866"}}}
--
Prof. Martin Odersky
LAMP/IC, EPFL
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typer#ensureReported's comment outlines an example where errors
could go unreported, resulting in error trees after typer without
any reported error messages. This commit makes sure that at least
one error is reported if a tree node has an error type.
Fixes #1802.
Review by @felixmulder ?