Skip to content

Faster scripted test #18116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Faster scripted test #18116

merged 1 commit into from
Jul 3, 2023

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Jul 2, 2023

Problem

edit-scripted cycle is painfully slow right now because doc is really slow (and or crashes after running out of memory), but scripted tests do not need scaladoc jars.

Solution

This ports PublishBinPlugin from sbt/sbt (credits to @dwijnand sbt/sbt#2725), which implements publishLocalBin, which skips scaladoc publishing, and makes edit-scripted cycle faster.

Problem
-------
edit-scripted cycle is painfully slow right now because `doc`
is really slow (and or crashes after running out of memory),
but scripted tests do not need scaladoc jars.

Solution
--------
This ports `PublishBinPlugin` from sbt/sbt (credits to dwijnand sbt/sbt#2725),
which implements `publishLocalBin`, which skips scaladoc publishing,
and makes edit-scripted cycle faster.
@bishabosha
Copy link
Member

bishabosha commented Jul 3, 2023

FWIW I am always adding the disableDocSetting to commonSettings in my dev workflow so this would be very welcome

@bishabosha bishabosha requested a review from smarter July 3, 2023 08:53
@bishabosha bishabosha requested review from adpi2 and dwijnand July 3, 2023 08:53
@bishabosha bishabosha assigned dwijnand and unassigned smarter Jul 3, 2023
@dwijnand dwijnand merged commit 69081e6 into scala:main Jul 3, 2023
@eed3si9n eed3si9n deleted the wip/scripted branch July 3, 2023 13:09
Kordyjan added a commit that referenced this pull request Dec 8, 2023
Backports #18116 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants