Skip to content

Stdlib bootstrapped explicit types #18029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

The first commit cloned the original source files. The second commit adds explicit result types.

@nicolasstucki
Copy link
Contributor Author

The test failed due to #18033. We need to wait until this PR is merged to re-test.

@nicolasstucki nicolasstucki force-pushed the stdlib-boostrapped-explicit-types branch from 6643a9e to b358290 Compare June 22, 2023 08:01
@nicolasstucki nicolasstucki marked this pull request as ready for review June 22, 2023 14:32
@nicolasstucki nicolasstucki requested a review from sjrd June 22, 2023 14:32
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #18032

@nicolasstucki nicolasstucki assigned nicolasstucki and unassigned sjrd Jun 23, 2023
@nicolasstucki
Copy link
Contributor Author

I will change this directly is Scala 2

nicolasstucki added a commit to nicolasstucki/scala that referenced this pull request Jun 26, 2023
Add explicit result type to methods where Scala 2 and Scala 3 disagree
with the inferred type. The aim is to have the same type in the Scala 2
pickles and the Scala 3 TASTy.

Follow up of scala#10435

These where identified in and tested in
  * scala/scala3#18032
  * scala/scala3#18029
  * scala/scala3#17975 (BitSet)
@SethTisue SethTisue changed the title Stdlib boostrapped explicit types Stdlib bootstrapped explicit types Jul 6, 2023
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree
with the inferred type. The aim is to have the same type in the Scala 2
pickles and the Scala 3 TASTy.

Follow up of scala/scala#10435

These where identified in and tested in
  * scala#18032
  * scala#18029
  * scala#17975 (BitSet)
hamzaremmal pushed a commit that referenced this pull request May 7, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree
with the inferred type. The aim is to have the same type in the Scala 2
pickles and the Scala 3 TASTy.

Follow up of scala/scala#10435

These where identified in and tested in
  * #18032
  * #18029
  * #17975 (BitSet)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants