Generate only TASTy in stdlib-bootstrapped
#17909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
stdlib-bootstrapped-tasty-only
branch
6 times, most recently
from
4ac8949 to
22f9089
Compare
nicolasstucki
force-pushed
the
stdlib-bootstrapped-tasty-only
branch
from
22f9089 to
6b7889b
Compare
sjrd
reviewed
Jul 4, 2023
Comment on lines
+1084
to
+1088
| exportJars := true, | ||
| Compile / packageBin / mappings := { | ||
| (`stdlib-bootstrapped` / Compile / packageBin / mappings).value | ||
| .filter(_._2.endsWith(".tasty")) | ||
| }, |
There was a problem hiding this comment.
Those settings couldn't go directly in stdlib-boostrapped? Why is this additional project necessary?
There was a problem hiding this comment.
This is the solution you proposed to be able to test MiMa (classfiles) on stdlib-bootstrapped and also have a jar with TASTy only.
An alternative would be to stop testing MiMa and only rely on TASTy MiMa.
sjrd
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.