Skip to content

Add stdlib blacklist and whitelist more sources. #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 18, 2016
Merged

Add stdlib blacklist and whitelist more sources. #1788

merged 23 commits into from
Dec 18, 2016

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@felixmulder
Copy link
Contributor

Hey @SethTisue! The validate-main thing is still showing up and seems stuck :(

@SethTisue
Copy link
Member

@felixmulder I can't seem to locate anything else to switch off at our end. perhaps you need to switch something off at https://github.com/lampepfl/dotty/settings/hooks...?

@SethTisue
Copy link
Member

and/or get rid of your scripts/jobs/validate directory, or the whole scripts directory?

@SethTisue
Copy link
Member

and/or find out what or where "dotty-bot" even is?

@felixmulder
Copy link
Contributor

@SethTisue, I see - the CLA checking is on our bot not yours. Disabled the webhook!

@odersky
Copy link
Contributor

odersky commented Dec 15, 2016

It seems the two CI's disagree. Does anybody know what's the root cause?

@nicolasstucki
Copy link
Contributor Author

It looks like the new CI did not update the scala-scala/dotty-library dependency.

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Dec 15, 2016 •
edited
Loading

@felixmulder any insight about this? Was it cached?

@nicolasstucki nicolasstucki force-pushed the add-bstdlib-blacklist branch 2 times, most recently from 7bb5471 to 35bb577 Compare December 17, 2016 10:19
@odersky
Copy link
Contributor

odersky commented Dec 17, 2016

@nicolasstucki Can you add Function0..Function22, Tuple1..Tuple22, and also control.{Try, Exception} to the whitelist? These should all be fixed now.

@nicolasstucki nicolasstucki force-pushed the add-bstdlib-blacklist branch 2 times, most recently from 93a0dbf to 03974f3 Compare December 17, 2016 17:12
@odersky
Copy link
Contributor

odersky commented Dec 17, 2016

@nicolasstucki Please, just LGTM/merge my fixes when you need them. No need to cherrypick in your PR. I am really hoping for faster reviews anyway. This constant piling up is causing me a lot of work. Thanks!

@nicolasstucki nicolasstucki force-pushed the add-bstdlib-blacklist branch 2 times, most recently from 098ad9e to 9acc4ef Compare December 17, 2016 18:35
@odersky
Copy link
Contributor

odersky commented Dec 18, 2016

LGTM! 👍 Let's get this in now. I'll try to move some items from black to white in a follow-on PR.

@odersky odersky merged commit 59f783a into scala:master Dec 18, 2016
@allanrenucci allanrenucci deleted the add-bstdlib-blacklist branch December 14, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkDimius DarkDimius Awaiting requested review from DarkDimius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolasstucki @felixmulder @SethTisue @odersky @dottybot