Teach PostTyper to handle untupled context closures #17739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fwiw, Dale and I looked at this together and this fix seems elegant to me the methods we're calling are more powerful than is strictly necessary here, but regardless, calling them seems more elegant than adding another case to the match (it would be a complicated case since the additional tree shape we're handling isn't a simple shape) |
odersky
approved these changes
Jun 5, 2023
| tree match | ||
| case Select(qual, _) => check(qual) // simple select _n | ||
| case Apply(TypeApply(Select(qual, _), _), _) => check(qual) // generic select .apply[T](n) | ||
| appliedCore(closureBody(tree)) match |
There was a problem hiding this comment.
Looks like a great fix. Since appliedCore is now used from outside TreeInfo, it would be good to give it a doc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.