Ignore tests/pos-with-compiler-cc/dotc in VS Code search

[mbovel]

Since the addition of tests/pos-with-compiler-cc/dotc, I often lost time ending up in a tests/pos-with-compiler-cc/dotc file instead of the expected compiler/src/dotty/tools/dotc equivalent. I also often saw other contributors experiencing the same problem during sprees.

To solve this, I propose to exclude tests/pos-with-compiler-cc/dotc files from VS Code search by adding it to search.exclude list setting.

Before:

After:

Note that to also exclude these files from full-text search, you also need to make sure this mysterious thing is checked:

See also: https://stackoverflow.com/questions/29971600/choose-folders-to-be-ignored-during-search-in-vs-code.

[ckipp01]

I'm not a VS Code user, so ignore me if the answer is obvious 😆, but I see we also have https://github.com/lampepfl/dotty/blob/main/.vscode-template/settings.json. Could these be combined, or is there a reason we need the .vscode-template and the .vscode settings?

[mbovel]

Oh, I didn't know about this. This folder is copied to .vscode by SBT if it doesn't exist:

https://github.com/lampepfl/dotty/blob/28915c4bd20182486b3e11136cf79af516da23b0/project/Build.scala#L226-L227

I find it a fragile approach because:

1. it means newcomers should run SBT before opening the project,
2. if we add settings there, like this PR does, they will not apply to existing installations.

I think we should just commit .vscode directly like it's commonly done.

[mbovel]

Okay, for now I just updated .vscode-template/settings.json instead of committing .vscode/settings.json.

[ckipp01]

I'll defer to the VS Code users, but if you see this biting people, then is makes sense imo. LGTM

[odersky]

Yes, I think that PR a good idea