Fix colons in printer #1742
Merged
Fix colons in printer #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
This is done so that we can use show for the entire method except for the ascribed type added by the compiler on success.
rethab
reviewed
Nov 24, 2016
| scala> x = x + 1 | ||
| x: Int = 1 | ||
| scala> x *= 2 | ||
| scala> x | ||
| res2: Int = 2 | ||
| val res2: Int = 2 |
There was a problem hiding this comment.
I was hesitant to do this. Looks very odd to me given that we initially created x as a var.
There was a problem hiding this comment.
Indeed, the REPL currently has semantics that are not well defined. There's no spec for it 😅
But, if you want to have a closer look at its semantics, by all means! We'd be happy to get something that is clearer :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes off where @rethab started and fixes defs not being properly printed when desugared to
TypeExpr.It does not fix the underlying issues with the REPL. The current strategy employed by the REPL is to gather all the types that were generated during a compilation and tie them to the correct names. This proves an issue though, because the types need to get printed using special hacks.
Ideally we would do an actual compile run and then just show the types without any distortion. But this I leave up to a later point in time when we're doing a more complete overhaul.
review: @OlivierBlanvillain