Environmentally friendly tests #1739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbt adds the correct jars to classpath and the tests depend on `packageAll` which creates these. When using something else however, these together with `sbt-interfaces` do not get propagated from the build. To remedy this and make the testing a bit more flexible, we now take these from `sys.props` instead, see `tests/dotty/Jars.scala`. If the props aren't defined we fall back to the ones default to sbt.
-verbose output was suppressed like all other non-error output in the tests. Now we don't filter output if -verbose is set.
felixmulder
commented
Nov 23, 2016
| val f = new JFile(getClass.getProtectionDomain.getCodeSource.getLocation.getPath) | ||
| println(f) | ||
| println(System.getProperty("java.class.path")) | ||
|
|
There was a problem hiding this comment.
Note to self: get rid of this addition
| |separated list of jars. | ||
| | | ||
| |When compiling with eclipse, you need the sbt-interfaces jar, but | ||
| |it in extras.""" |
Fengyun's original solution was the right one. We cannot NOT enter a package class into its parent scope, because reloading the denotation with .member will fail. So we need to enter it and compensate by adding a clause to `qualifies` in `typedIdent`. Weirdly, this was noted only when running tasty_bootstrap from a custom classpath in the new build setup. So it was pretty tricky to diagnose.
felixmulder
force-pushed
the
topic/environmentally-friendly-tests
branch
from
781fb87 to
6d4a98c
Compare
|
@smarter - would you mind reviewing? |
smarter
reviewed
Nov 24, 2016
| | - DOTTY_INTERFACES | ||
| | - DOTTY_EXTRAS | ||
| | | ||
| |Where these all contain locations, except extras which is a comma |
felixmulder
force-pushed
the
topic/environmentally-friendly-tests
branch
from
6d4a98c to
2f1a794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.