Skip to content

Patmat #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

Patmat #172

wants to merge 23 commits into from

Conversation

DarkDimius
Copy link
Contributor

@odersky this branch has a pattern matcher that passes test, that doesn't yet add outer checks and doesn't use switches.
Unfortunatelly typer dies on this branch on compiling the pattern matcher itself https://gist.github.com/DarkDimius/2e40747122e780e5755a

I'm starting to rebase it over #171 and will make a PR with all the changes and todo's.

@odersky
Copy link
Contributor

odersky commented Sep 12, 2014

Hi Dmitry,

NamedType handling has changed a bit with the later PRs including
explicitOuter and capturedVars. Several possible data races were
eliminated. Can you rebase the pattern matcher to capturedVars and check
whether the problem persists? In that case I'll take a look over the
weekend.

Martin

On Tue, Sep 9, 2014 at 4:49 PM, Dmitry Petrashko notifications@github.com
wrote:

@odersky https://github.com/odersky this branch has a pattern matcher
that passes test, that doesn't yet add outer checks and doesn't use
switches.
Unfortunatelly typer dies on this branch on compiling the pattern matcher
itself https://gist.github.com/DarkDimius/2e40747122e780e5755a

I'm starting to rebase it over #171
#171 and will make a PR with all

the changes and todo's.

You can merge this Pull Request by running

git pull https://github.com/dotty-staging/dotty patmat

Or view, comment on, or merge it at:

#172
Commit Summary

  • Allow converting junit test to scalameter benchmark
  • Definitions used by pattern matcher
  • initValue helper method
  • Making all case classes implement Product. Requires adding Product0
  • Unapply doc update
  • More complicated patterns.
  • Definitions used by patmat
  • Common functionality to be shared between patmat and typer
  • CommonCodegen for patMat
  • Optimized codegen for patmat
  • TreeMakers for patmat
  • add Substitution to patmat.
  • Match translator for patmat
  • Pattern expanders for patmat
  • Helper methods for patmat
  • Adapting patmat for dotty
  • more of adapting patmat for dotty
  • More fixes, added _id for internal tracking of failures
  • Most of tests succeed now.
  • Everything except unapplySeq doesn't explode.
  • Fixed unapplySeq. Patmat passes all test suite but typer itself
    breaks on it.
  • Remaining definitions for patmat.
  • Remove dead code and add todo about outer tests not being generated

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#172.

Martin Odersky
EPFL

@DarkDimius DarkDimius closed this Oct 11, 2014
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
Backport "Spec: Integrate the specification for match types." to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants