Skip to content

Strip index.html from external API url #17112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

armanbilge
Copy link
Contributor

Ports this fix from Scaladoc 2.

https://github.com/scala/scala/blob/15538c7365bbb03f37d06b59f050241683972c71/src/scaladoc/scala/tools/nsc/doc/Settings.scala#L281-L287

Without it, links to external docs are broken for several libraries.

@armanbilge armanbilge closed this Mar 20, 2023
@armanbilge armanbilge reopened this Mar 20, 2023
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks @armanbilge!

@ckipp01 ckipp01 merged commit 2e30211 into scala:main Mar 30, 2023
Dedelweiss pushed a commit to Dedelweiss/dotty that referenced this pull request Apr 17, 2023
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants