Add an error message for incorrect sequence wildcard position Parsers.scala:1425 and Parsers.scala:1079 #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
suggested changes
Nov 14, 2016
| @@ -787,4 +787,24 @@ object messages { | |||
| val msg = "unreachable code" | |||
| val explanation = "" | |||
| } | |||
|
|
|||
| case class IncorrectSequenceWildcardPatternPosition()(implicit ctx: Context) extends Message(31) { | |||
There was a problem hiding this comment.
Could we make this name a little shorter? How about: SeqWildcardPatternPos?
| |def sumOfTheFirstTwo(list: List[Int]): Int = list match { | ||
| | case List(first, second, x:_*) => first + second | ||
| | case _ => 0 | ||
| |} |
There was a problem hiding this comment.
To get highlighting on this part pull it out to a variable like:
val code = "def sumOfThe..."
hl"""|Sequence wildcard pattern is expected at the end of an argument list.
|This pattern matches any remaining elements in a sequence.
|Consider the following example:
|
|$code
|
|..."""And for the code under Calling:
interpolate it like:
|Calling:
|
|${"sumOfTheFirstTwo(List(1, 2, 10))"}
|
|would give 3 as a result"""
this will highlight the code.
|
@felixmulder PTAL |
felixmulder
approved these changes
Nov 14, 2016
|
LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to the following issue.