Fix benchmarks and add multiple mini benchmark tests #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review @felixmulder and @DarkDimius ? |
DarkDimius
reviewed
Nov 15, 2016
| @@ -74,11 +76,24 @@ object BenchTests extends OnlineRegressionReport { | |||
| def setup = | |||
| performance of "dotty" in { | |||
| measure.method("stdlib") in { | |||
| using(Gen.unit("test")) curve "stdlib" in { r => stdLib } | |||
| // maybe scalac curve later | |||
| using(Gen.unit("test")) curve "dotty" in { r => stdLib } | |||
There was a problem hiding this comment.
why is this curve called dotty now?
There was a problem hiding this comment.
@DarkDimius The curve is to support multiple curves in a chart. Yes, I should keep it the same for stdlib and dotty-src for backward data compatibility.
There was a problem hiding this comment.
@DarkDimius the name for stdlib and dotty-src are now restored.
|
Status? |
|
@DarkDimius This is one is up to you to review, thanks :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks has been down due to some weird error. A single line change fix it: link
And I've added several mini tests which covers implicit search, exhaustivity check, tailrec, etc. We can just put any mini test to the folder
bench/tests, it will be automatically tracked in the benchmarks.