Add error message for illegal literals - Parser.scala:602 #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
suggested changes
Nov 6, 2016
| | - Character Literals: 'a', '\u0041', '\\n' | ||
| | - String Literals: "Hello, World!" | ||
| | - null | ||
| |""".stripMargin |
There was a problem hiding this comment.
Strip margin isn't necessary on hl strings :)
| | - Integer literals: 0, 21, 0xFFFFFFFF, -42L | ||
| | - Floating Point Literals: 0.0, 1e30f, 3.14159f, 1.0e-100, .1 | ||
| | - Boolean Literals: true, false | ||
| | - Character Literals: 'a', '\u0041', '\\n' |
There was a problem hiding this comment.
There shouldn't be an extra \ in '\\n' right? You don't need to escape things (except $) in triple quoted strings.
| val kind = "Syntax" | ||
| val msg = "illegal literal" | ||
| val explanation = | ||
| hl"""|Expected a valid literal. |
There was a problem hiding this comment.
I would skip this line, the error message already says "illegal literal" right? If you think it should be kept, you could bake it into the sentence where you present the legal literals in Scala.
|
@felixmulder PTAL |
|
LGTM |
smarter
reviewed
Nov 6, 2016
| val kind = "Syntax" | ||
| val msg = "illegal literal" | ||
| val explanation = | ||
| hl"""|Available literals can be divided into the several groups: |
There was a problem hiding this comment.
typo: "into the several groups" -> "into several groups"
There was a problem hiding this comment.
Oh, snap! Sorry for this typo guys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to the following issue