Skip to content

Fix #1639: Changes around implicits and apply methods #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2016
Merged

Fix #1639: Changes around implicits and apply methods #1658

merged 3 commits into from
Dec 3, 2016

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 5, 2016

While trying to fix #1639 I discovered two other areas where things could be improved. The PR contains:

Review by @smarter

@odersky
Better reporting of nested implicit failures
e6e47f1 
Error messages of nested implicit failures are now
reported with the top-level message if -explaintypes is set.
@odersky
Avoid recomputation of companionRefs
b21f954 
When tracing i1639.scala it became apparent that we compute
a lot of companion refs. This commit avoids this by better
book-keeping what is valid and what is not and more
aggressive caching.
@odersky
Avoid inserting multiple .apply's.
d8f5c6c 
This can lead to stackoverflow, as i1639.scala shows.

Fixes scala#1639.
@odersky
Copy link
Contributor Author

odersky commented Nov 24, 2016

Rebased to master

@odersky odersky merged commit 9ceed92 into scala:master Dec 3, 2016
@odersky odersky mentioned this pull request Dec 3, 2016
Closed
@allanrenucci allanrenucci deleted the fix-#1639 branch December 14, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stack overflow compiling single-arg implicit constructor with empty auxiliary ctor
1 participant
@odersky