Avoid calling unsupported computeHash in some situations #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some types do not implement `computeHash`, instead they override `myHash` directly. This works fine as long as `myHash` is not equal to `HashUnknown` but this was not guaranteed before this commit, if `myHash` is equal to `HashUnknown` then `computeHash` is called by `CachedGroundType#hash` or `CachedProxyType#hash` causing an exception: https://gist.github.com/smarter/6b642db0495e995d8f3c26d614cf54d6 This commit fixes this by making sure we never compute a hash equal to `HashUnknown`, instead `HashUnknownAlt` should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types do not implement
computeHash, instead they overridemyHashdirectly. This works fine as long asmyHashis not equal toHashUnknownbut this was not guaranteed before this commit, ifmyHashis equal toHashUnknownthencomputeHashis called byCachedGroundType#hashorCachedProxyType#hashcausing an exception:https://gist.github.com/smarter/6b642db0495e995d8f3c26d614cf54d6
This commit fixes this by making sure we never compute a hash equal to
HashUnknown, insteadHashUnknownAltshould be used.Review by @odersky